third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2515923002: Remove redundant 'derived constraint space' setters from NGConstraintSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2515923002: Remove redundant 'derived constraint space' setters from NGConstraintSpace (Closed)

Patch Set: sync to the head Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index b8a8cd633153ffa9614864b79449c87e8ccc5dbd..1ad88aa0c857a407aadf61a150d23f43f794a132 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -167,10 +167,14 @@ TEST_F(NGBlockLayoutAlgorithmTest, CollapsingMarginsCase1) {

div1->SetFirstChild(div2);

- auto* space = ConstructConstraintSpace(

- HorizontalTopBottom, LTR,

- NGLogicalSize(LayoutUnit(100), NGSizeIndefinite));

- space->SetIsNewFormattingContext(true);

+ NGLogicalSize size(LayoutUnit(100), NGSizeIndefinite);

+ NGConstraintSpaceBuilder builder(HorizontalTopBottom);

+ builder.SetAvailableSize(size)

+ .SetPercentageResolutionSize(size)

+ .SetIsNewFormattingContext(true);

+ auto* space = new NGConstraintSpace(HorizontalTopBottom, LTR,

+ builder.ToConstraintSpace());

NGPhysicalFragment* frag = RunBlockLayoutAlgorithm(space, div1);

EXPECT_TRUE(frag->MarginStrut().IsEmpty());