chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java - Issue 2515713002: Move fetching new suggestions for all categories to the SuggestionsSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2515713002: Move fetching new suggestions for all categories to the SuggestionsSource. (Closed)

Patch Set: x Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

index cd3c067788dac92b22b65bdf8071483891361d0f..b550990981e259578a40e47a020c922546af21b0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

@@ -69,7 +69,7 @@ class ActionItem extends OptionalLeaf {

}

@VisibleForTesting

- void performAction(NewTabPageManager manager, NewTabPageAdapter adapter) {

+ void performAction(NewTabPageManager manager) {

manager.trackSnippetCategoryActionClick(mCategoryInfo.getCategory(), getPosition());

switch (mCurrentAction) {

@@ -109,8 +109,7 @@ class ActionItem extends OptionalLeaf {

.setOnClickListener(new View.OnClickListener() {

@Override

public void onClick(View v) {

- mActionListItem.performAction(

- manager, recyclerView.getNewTabPageAdapter());

+ mActionListItem.performAction(manager);

}

});