[DevTools] Handle external link clicks and context menu separately.

[DevTools] Handle external link clicks and context menu separately.

BUG=665661
Committed: https://crrev.com/1545da6cad6e84e6206f4be68ea443792bacb889
Cr-Commit-Position: refs/heads/master@{#433331}

[dgozman, 2016-11-17 23:10:24]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2016-11-17 23:10:25]

Could you please take a look?

[lushnikov, 2016-11-18 00:39:18]

lgtm

https://codereview.chromium.org/2512013002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
(right):

https://codereview.chromium.org/2512013002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js:1214:
var anchor = node.nodeName().toLowerCase() === 'a' ?
UI.createExternalLink(rewrittenHref, value, '', true) :
why do you want to preventClick here?

[dgozman, 2016-11-18 06:55:12]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-18 06:55:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 10:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 10:24:42]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/main/Main.js:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/main/Main.js:190
  error: third_party/WebKit/Source/devtools/front_end/main/Main.js: patch does
not apply

Patch:       third_party/WebKit/Source/devtools/front_end/main/Main.js
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js
b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index
de094030b0c7a2d8408d55e2c69cc5fd92023570..d53aa36c94361e5071eceaadd0825dffb96c15d6
100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -190,10 +190,8 @@ Main.Main = class {
         new
Bindings.FileSystemWorkspaceBinding(Workspace.isolatedFileSystemManager,
Workspace.workspace);
     Main.networkProjectManager = new
Bindings.NetworkProjectManager(SDK.targetManager, Workspace.workspace);
     Bindings.presentationConsoleMessageHelper = new
Bindings.PresentationConsoleMessageHelper(Workspace.workspace);
-    Bindings.cssWorkspaceBinding =
-        new Bindings.CSSWorkspaceBinding(SDK.targetManager,
Workspace.workspace);
-    Bindings.debuggerWorkspaceBinding =
-        new Bindings.DebuggerWorkspaceBinding(SDK.targetManager,
Workspace.workspace);
+    Bindings.cssWorkspaceBinding = new
Bindings.CSSWorkspaceBinding(SDK.targetManager, Workspace.workspace);
+    Bindings.debuggerWorkspaceBinding = new
Bindings.DebuggerWorkspaceBinding(SDK.targetManager, Workspace.workspace);
     Bindings.breakpointManager =
         new Bindings.BreakpointManager(null, Workspace.workspace,
SDK.targetManager, Bindings.debuggerWorkspaceBinding);
     Extensions.extensionServer = new Extensions.ExtensionServer();
@@ -391,10 +389,7 @@ Main.Main = class {
       InspectorFrontendHost.openInNewTab(anchor.href);
     }
 
-    if (!anchor.classList.contains('webkit-html-external-link'))
-      followLink();
-    else
-      InspectorFrontendHost.openInNewTab(anchor.href);
+    followLink();
   }
 
   _registerShortcuts() {

[dgozman, 2016-11-18 18:00:46]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-11-18 18:00:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2512013002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-18 18:02:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:20:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-11-18 23:09:58]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-18 23:10:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 23:37:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-18 23:39:42]

Description was changed from

==========
[DevTools] Handle external link clicks and context menu separately.

BUG=665661
==========

to

==========
[DevTools] Handle external link clicks and context menu separately.

BUG=665661

Committed: https://crrev.com/1545da6cad6e84e6206f4be68ea443792bacb889
Cr-Commit-Position: refs/heads/master@{#433331}
==========

[commit-bot: I haz the power, 2016-11-18 23:39:43]

Patchset 3 (id:??) landed as
https://crrev.com/1545da6cad6e84e6206f4be68ea443792bacb889
Cr-Commit-Position: refs/heads/master@{#433331}