Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2515243003: Remove FwlEventMask (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FwlEventMask The only value being set from the enum was the All Mask. This was always set through the default value in the methods. This Cl removes the mask code completely and updates surrounding code as needed. Committed: https://pdfium.googlesource.com/pdfium/+/4bd717ba4e40d4d3775c5e19334f4733fca8cb42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -81 lines) Patch
M xfa/fwl/core/cfwl_event.h View 1 chunk +0 lines, -13 lines 0 comments Download
M xfa/fwl/core/cfwl_eventtarget.h View 2 chunks +4 lines, -5 lines 0 comments Download
M xfa/fwl/core/cfwl_eventtarget.cpp View 1 chunk +8 lines, -51 lines 0 comments Download
M xfa/fwl/core/cfwl_notedriver.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_notedriver.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-21 20:17:34 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-21 20:19:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515243003/1
4 years, 1 month ago (2016-11-22 01:36:24 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 01:57:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4bd717ba4e40d4d3775c5e19334f4733fca8...

Powered by Google App Engine
This is Rietveld 408576698