Split fwl/core class pt II.

Split fwl/core class pt II.

Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_Widget::DataProvider
directly.

Committed: https://pdfium.googlesource.com/pdfium/+/37b6d1479b1674eb239cea8893eea31274d22ecd

[dsinclair, 2016-11-21 19:53:22]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-21 19:53:23]

PTAL.

[npm, 2016-11-21 21:21:46]

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_event...
File xfa/fwl/core/cfwl_eventtarget.h (right):

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_event...
xfa/fwl/core/cfwl_eventtarget.h:22: uint32_t dwFilter = FWL_EVENT_ALL_MASK);
Is default parameter needed?

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_widge...
File xfa/fwl/core/cfwl_widgetmgr.cpp (right):

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.cpp:41: m_mapWidgetItem[nullptr].reset(new Item);
MakeUnique?

[dsinclair, 2016-11-21 21:57:08]

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_event...
File xfa/fwl/core/cfwl_eventtarget.h (right):

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_event...
xfa/fwl/core/cfwl_eventtarget.h:22: uint32_t dwFilter = FWL_EVENT_ALL_MASK);
On 2016/11/21 21:21:46, npm wrote:
> Is default parameter needed?

Followup.

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_widge...
File xfa/fwl/core/cfwl_widgetmgr.cpp (right):

https://codereview.chromium.org/2520063002/diff/20001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widgetmgr.cpp:41: m_mapWidgetItem[nullptr].reset(new Item);
On 2016/11/21 21:21:46, npm wrote:
> MakeUnique?

Done.

[Tom Sepez, 2016-11-21 22:32:28]

lgtm

[dsinclair, 2016-11-21 22:49:51]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-21 22:49:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 23:31:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:31:48]

Try jobs failed on following builders:
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/2915)

[dsinclair, 2016-11-22 00:53:58]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-22 00:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2520063002/#ps60001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-11-22 00:54:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:05:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479776038279720,
"parent_rev": "6a1c9bd09ef8fdd2fe2f9e39b9a05f6581be9d87", "commit_rev":
"37b6d1479b1674eb239cea8893eea31274d22ecd"}

[commit-bot: I haz the power, 2016-11-22 01:06:01]

Description was changed from

==========
Split fwl/core class pt II.

Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_Widget::DataProvider
directly.
==========

to

==========
Split fwl/core class pt II.

Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_Widget::DataProvider
directly.

Committed:
https://pdfium.googlesource.com/pdfium/+/37b6d1479b1674eb239cea8893eea31274d2...
==========

[commit-bot: I haz the power, 2016-11-22 01:06:02]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/37b6d1479b1674eb239cea8893eea31274d2...