Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2522663002: Remove the GetCaption dataprovider method (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove the GetCaption dataprovider method This method mostly returns L"". In the one case where it returns something different the value is substituted into the callsite. The IFWL_Tooltip class was using the caption, but it is not currently being used. Removed as well. Committed: https://pdfium.googlesource.com/pdfium/+/4572c8a20beee5cbab2eb1a90cb6cadcc5fa512c

Patch Set 1 #

Patch Set 2 : Remove tooltip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -422 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_barcode.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_barcode.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/core/cfwl_notedriver.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_notedriver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_picturebox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.cpp View 1 4 chunks +6 lines, -22 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.cpp View 4 chunks +0 lines, -56 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.h View 1 1 chunk +0 lines, -72 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.cpp View 1 1 chunk +0 lines, -206 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 chunk +1 line, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-21 20:52:45 UTC) #3
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-21 21:06:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522663002/20001
4 years, 1 month ago (2016-11-22 01:58:34 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:11:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4572c8a20beee5cbab2eb1a90cb6cadcc5fa...

Powered by Google App Engine
This is Rietveld 408576698