Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2514893004: DevTools: show array entries that are getters (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT DevTools: show array entries that are getters Currently, array entries that are accessors are shown for array evaluations but not for arrays printed in object format. This CL moves accessor formatting logic into RemoteObjectPreviewFormatter so that both formats can show array entry accessors. Once the corresponding CL turns on accessors in injected script source, this will need manual rebaseline: https://codereview.chromium.org/2508423002/ BUG=666882

Patch Set 1 #

Patch Set 2 : Add needsManualRebase to TE #

Messages

Total messages: 7 (6 generated)
luoe
4 years, 1 month ago (2016-11-18 22:45:36 UTC) #4

          

Powered by Google App Engine
This is Rietveld 408576698