third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js - Issue 2514893004: DevTools: show array entries that are getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2514893004: DevTools: show array entries that are getters (Closed)

Patch Set: Add needsManualRebase to TE Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

index 2d978c8bb4926eee92106dec4034d23d129162c7..e70ebfc82372deca4deee5e28ba2e65c240eca9c 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

@@ -787,7 +787,7 @@ Sources.JavaScriptSourceFrame = class extends Sources.UISourceCodeFrame {

var propertyCount = value.preview ? value.preview.properties.length : 0;

var entryCount = value.preview && value.preview.entries ? value.preview.entries.length : 0;

if (value.preview && propertyCount + entryCount < 10)

- formatter.appendObjectPreview(nameValuePair, value.preview);

+ formatter.appendObjectPreview(nameValuePair, value.preview, value);

else

nameValuePair.appendChild(Components.ObjectPropertiesSection.createValueElement(value, false));

++renderedNameCount;

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | no next file » | no next file with comments »