Issue 2515913002: DevTools: object formatter renders arrays the same way as printArrayResult()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2515913002: DevTools: object formatter renders arrays the same way as printArrayResult() (Closed)

Created:
4 years, 1 month ago by luoe

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: object formatter renders arrays the same way as printArrayResult() This CL starts merging array formats by copying the logic defined in ConsoleViewMessage's formatParameterAsArray() into RemoteObjectPreviewFormatter. The old version is left currently for ease of review and will be removed later. BUG=666882

Patch Set 1 #

Patch Set 2 : DevTools: object formatter renders arrays the same way as printArrayResult() #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -52 lines)			Patch
M	third_party/WebKit/LayoutTests/inspector/console/console-format-array-prototype-expected.txt	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-format-collections-expected.txt	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-inline-values-expected.txt	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js	View	1	6 chunks	+63 lines, -33 lines	0 comments	Download

Depends on Patchset:

Issue 2514893004 Patch 20001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

luoe

4 years, 1 month ago (2016-11-18 23:43:34 UTC) #1

Description was changed from

==========
DevTools: object formatter renders arrays the same way as printArrayResult()

BUG=666882
==========

to

==========
DevTools: object formatter renders arrays the same way as printArrayResult()

This CL starts merging array formats by copying the logic defined in
ConsoleViewMessage's formatParameterAsArray() into RemoteObjectPreviewFormatter.
The old version is left currently for ease of review and will be removed later.

BUG=666882
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages