components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java - Issue 2514783002: [Cronet] Add callback wrapper classes to enforce API version checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java

Issue 2514783002: [Cronet] Add callback wrapper classes to enforce API version checking. (Closed)

Patch Set: fix JNIAdditionalImport Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java

index d29265d9ebb04b6516cc099945d326d704b4a886..26147c2632d04ac24b293ac4e58ca69bd9309767 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java

@@ -87,7 +87,7 @@ public class CronetEngineBuilderImpl extends ICronetEngineBuilder {

private String mUserAgent;

private String mStoragePath;

private boolean mLegacyModeEnabled;

- private CronetEngine.Builder.LibraryLoader mLibraryLoader;

+ private VersionSafeCallbacks.LibraryLoader mLibraryLoader;

private boolean mQuicEnabled;

private boolean mHttp2Enabled;

private boolean mSdchEnabled;

@@ -158,11 +158,11 @@ public class CronetEngineBuilderImpl extends ICronetEngineBuilder {

@Override

public CronetEngineBuilderImpl setLibraryLoader(CronetEngine.Builder.LibraryLoader loader) {

- mLibraryLoader = loader;

+ mLibraryLoader = new VersionSafeCallbacks.LibraryLoader(loader);

return this;

}

- CronetEngine.Builder.LibraryLoader libraryLoader() {

+ VersionSafeCallbacks.LibraryLoader libraryLoader() {

return mLibraryLoader;

}