components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java - Issue 2514783002: [Cronet] Add callback wrapper classes to enforce API version checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

Issue 2514783002: [Cronet] Add callback wrapper classes to enforce API version checking. (Closed)

Patch Set: fix JNIAdditionalImport Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

index bbf20ad2214dde42d6706da39ed9e7020e891ca6..824ae87781ad7c22b2a27cddc8b40498a75a5b15 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

@@ -36,7 +36,7 @@ public final class CronetUploadDataStream extends UploadDataSink {

private static final String TAG = "CronetUploadDataStream";

// These are never changed, once a request starts.

private final Executor mExecutor;

- private final UploadDataProvider mDataProvider;

+ private final VersionSafeCallbacks.UploadDataProviderWrapper mDataProvider;

private long mLength;

private long mRemainingLength;

private CronetUrlRequest mRequest;

@@ -98,7 +98,7 @@ public final class CronetUploadDataStream extends UploadDataSink {

public CronetUploadDataStream(UploadDataProvider dataProvider, Executor executor) {

mExecutor = executor;

- mDataProvider = dataProvider;

+ mDataProvider = new VersionSafeCallbacks.UploadDataProviderWrapper(dataProvider);

}

/**