components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java - Issue 2514783002: [Cronet] Add callback wrapper classes to enforce API version checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

Issue 2514783002: [Cronet] Add callback wrapper classes to enforce API version checking. (Closed)

Patch Set: fix JNIAdditionalImport Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

index c6ff968f2f0f162c2bb1da87b570d234155f9097..cee01da20755a28d3d03caa749cf6481c1148313 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

@@ -79,7 +79,7 @@ public class CronetBidirectionalStream extends ExperimentalBidirectionalStream {

private final CronetUrlRequestContext mRequestContext;

private final Executor mExecutor;

- private final Callback mCallback;

+ private final VersionSafeCallbacks.BidirectionalStreamCallback mCallback;

private final String mInitialUrl;

private final int mInitialPriority;

private final String mInitialMethod;

@@ -230,7 +230,7 @@ public class CronetBidirectionalStream extends ExperimentalBidirectionalStream {

mRequestContext = requestContext;

mInitialUrl = url;

mInitialPriority = convertStreamPriority(priority);

- mCallback = callback;

+ mCallback = new VersionSafeCallbacks.BidirectionalStreamCallback(callback);

mExecutor = executor;

mInitialMethod = httpMethod;

mRequestHeaders = stringsFromHeaderList(requestHeaders);