Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2514643002: DevTools: support all handlers that end up with function call in perfmonitor. (Closed)
Patch Set: review comments addressed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 931731e7fba306d54d005827ea352fda4fe5d598..cf85cbd2ba72140f3717c80bbda5598d9fea9e0f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -632,13 +632,13 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callFunction(
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kRunMicrotasks);
- PerformanceMonitor::willExecuteScript(context);
+ PerformanceMonitor::willCallFunction(context);
ThreadDebugger::willExecuteScript(isolate, function->ScriptId());
v8::MaybeLocal<v8::Value> result =
function->Call(isolate->GetCurrentContext(), receiver, argc, args);
crashIfIsolateIsDead(isolate);
ThreadDebugger::didExecuteScript(isolate);
- PerformanceMonitor::didExecuteScript(context);
+ PerformanceMonitor::didCallFunction(context, function);
if (!depth)
TRACE_EVENT_END0("devtools.timeline", "FunctionCall");
return result;

Powered by Google App Engine
This is Rietveld 408576698