third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp - Issue 2514643002: DevTools: support all handlers that end up with function call in perfmonitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp

Issue 2514643002: DevTools: support all handlers that end up with function call in perfmonitor. (Closed)

Patch Set: review comments addressed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp

diff --git a/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp b/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp

index 74dcbb75b8ad7deb042467fa0d8c6e3fe07a6b86..8ecc1e3779176311a622f9906791d40f3fc254a2 100644

--- a/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp

+++ b/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp

@@ -5,6 +5,7 @@

#include "core/dom/FrameRequestCallbackCollection.h"

#include "core/dom/FrameRequestCallback.h"

+#include "core/frame/PerformanceMonitor.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/InspectorTraceEvents.h"

@@ -78,6 +79,8 @@ void FrameRequestCallbackCollection::executeCallbacks(

InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(

m_context, "animationFrameFired", false);

InspectorInstrumentation::AsyncTask asyncTask(m_context, callback);

+ PerformanceMonitor::HandlerCall handlerCall(

+ m_context, "requestAnimationFrame", true);

if (callback->m_useLegacyTimeBase)

callback->handleEvent(highResNowMsLegacy);

else