third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp - Issue 2514643002: DevTools: support all handlers that end up with function call in perfmonitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Issue 2514643002: DevTools: support all handlers that end up with function call in perfmonitor. (Closed)

Patch Set: review comments addressed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

index 8f4048a6cbb75efd78faae6155043c99a60555e4..403c3d14ba72dfbed30bcb54ea92f4982612322a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

@@ -172,10 +172,4 @@ void ScheduledAction::createLocalHandlesForArgs(

handles->append(m_info.Get(i));

}

-std::unique_ptr<SourceLocation> ScheduledAction::handlerLocation() {

- v8::HandleScope handles(m_scriptState->isolate());

- return SourceLocation::fromFunction(

- v8::Local<v8::Function>::New(m_scriptState->isolate(), m_function.get()));

} // namespace blink