Ensure fake alert window attached to AXAura tree and refine alert dialog output

Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string alerts from callers. Previously, we were not attaching the window properly as a child of desktop. This resulted in some inconsistencies in the client (extension side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains duplicate text with the dialog's name. The alert dialog contains a name identical to the dialog, but contains the actual content and the allow, deny buttons.

This cl doesn't change the structure, but does allow the user to descend properly into the alert dialog with linear navigation. We do this by making an alert dialog a structural container (i.e. something we descend into when navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367 childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358 childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373 childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361 childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365 childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361 childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366 childIds=[]

TEST=visit site containing notification; ensure we get focused on that window and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we don't get any errors concerning invalid nodes on deserialization and that ChromeVox only alerts once.

BUG=619266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/319f110637783ce562ad6092120441756572e644
Cr-Commit-Position: refs/heads/master@{#433321}

[David Tseng, 2016-11-17 22:08:50]

Description was changed from

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=
==========

to

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-17 22:09:52]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-11-17 22:11:13]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[David Tseng, 2016-11-17 22:11:22]

Description was changed from

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=619266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-17 22:13:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-11-17 23:10:48]

lgtm

[commit-bot: I haz the power, 2016-11-18 03:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 03:36:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-11-18 15:27:06]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-11-18 15:27:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 17:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 17:52:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-11-18 18:51:16]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-18 18:51:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2514583002/#ps20001
(title: "Fix test.")

[commit-bot: I haz the power, 2016-11-18 18:51:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:44:51]

Description was changed from

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=619266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=619266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-18 22:44:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 22:55:25]

Description was changed from

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=619266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string
alerts from callers. Previously, we were not attaching the window properly as a
child of desktop. This resulted in some inconsistencies in the client (extension
side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire
subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains
duplicate text with the dialog's name. The alert dialog contains a name
identical to the dialog, but contains the actual content and the allow, deny
buttons.

This cl doesn't change the structure, but does allow the user to descend
properly into the alert dialog with linear navigation. We do this by making an
alert dialog a structural container (i.e. something we descend into when
navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367
childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358
childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373
childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361
childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365
childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361
childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366
childIds=[]

TEST=visit site containing notification; ensure we get focused on that window
and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we
don't get any errors concerning invalid nodes on deserialization and that
ChromeVox only alerts once.

BUG=619266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/319f110637783ce562ad6092120441756572e644
Cr-Commit-Position: refs/heads/master@{#433321}
==========

[commit-bot: I haz the power, 2016-11-18 22:55:26]

Patchset 2 (id:??) landed as
https://crrev.com/319f110637783ce562ad6092120441756572e644
Cr-Commit-Position: refs/heads/master@{#433321}