chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 2514583002: Ensure fake alert window attached to AXAura tree and refine alert dialog output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2514583002: Ensure fake alert window attached to AXAura tree and refine alert dialog output (Closed)

Patch Set: Fix test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js ('k') | chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index 6981549d8859b56bdcdbdb8cd41124d79f371459..7aa8abc27b8027817fb69af598fbde97aa5e39ca 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -400,8 +400,8 @@ Output.RULES = {

speak: '$earcon(ALERT_NONMODAL) $role $descendants $state'

alertDialog: {

- enter: '$nameFromNode $role $description',

- speak: '$name $role $descendants $state'

+ enter: '$earcon(ALERT_MODAL) $name $state',

+ speak: '$earcon(ALERT_MODAL) $name $descendants $state $role'

cell: {

enter: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +