chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc - Issue 2514583002: Ensure fake alert window attached to AXAura tree and refine alert dialog output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc

Issue 2514583002: Ensure fake alert window attached to AXAura tree and refine alert dialog output (Closed)

Patch Set: Fix test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc

diff --git a/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc b/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc

index f6befedfbf97482663ead017281f9fc43fdc69a7..94f59ee26e6bba50eef96e1cc73364d4aa77cdc8 100644

--- a/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc

+++ b/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc

@@ -144,9 +144,9 @@ TEST_F(AXTreeSourceAuraTest, Serialize) {

// This is the initial serialization.

ax_serializer.SerializeChanges(ax_tree.GetRoot(), &out_update);

- // The update should just be the desktop node since no events have been fired

- // on any controls, so no windows have been cached.

- ASSERT_EQ(1U, out_update.nodes.size());

+ // The update should just be the desktop node and the fake alert window we use

+ // to handle posting text alerts.

+ ASSERT_EQ(2U, out_update.nodes.size());

// Try removing some child views and re-adding which should fire some events.

content_->RemoveAllChildViews(false /* delete_children */);