Replace IDR window property use with gfx::ImageSkia icons.

Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/d3ddd7adb380ba163b9a598c4a12c85eb4fd30e0
Cr-Commit-Position: refs/heads/master@{#433082}

[msw, 2016-11-18 00:10:35]

Description was changed from

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
This reduces the codepaths for setting window icons.

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
==========

to

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
==========

[msw, 2016-11-18 00:10:50]

Hey James, please take a look; thanks!

[msw, 2016-11-18 00:10:57]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 00:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-11-18 00:34:49]

LGTM with nit.

For my info, is the plan for mus-aura to provide a window property serializer
for ImageSkia for the existing icon property?

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/settings_window_observer.cc (right):

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:92:
window->SetProperty(aura::client::kWindowIconKey, new gfx::ImageSkia(*icon));
nit: Maybe a comment about ownership of the icon pointers? (Like the fact that
kWindowIconKey is owned?)

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/task_manager_view.cc (right):

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/task_manager_view.cc:115:
window->SetProperty(aura::client::kWindowIconKey, new gfx::ImageSkia(*icon));
ditto

[msw, 2016-11-18 00:51:40]

On 2016/11/18 00:34:49, James Cook wrote:
> For my info, is the plan for mus-aura to provide a window property serializer
> for ImageSkia for the existing icon property?

Yes, this will be handled by aura::PropertyConverter.
(I'm actively working on that; image support will come soon)

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/settings_window_observer.cc (right):

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:92:
window->SetProperty(aura::client::kWindowIconKey, new gfx::ImageSkia(*icon));
On 2016/11/18 00:34:49, James Cook wrote:
> nit: Maybe a comment about ownership of the icon pointers? (Like the fact that
> kWindowIconKey is owned?)

Done. (though this is a fairly common pattern; title will do the same above)

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/task_manager_view.cc (right):

https://codereview.chromium.org/2514473003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/task_manager_view.cc:115:
window->SetProperty(aura::client::kWindowIconKey, new gfx::ImageSkia(*icon));
On 2016/11/18 00:34:49, James Cook wrote:
> ditto

Done.

[msw, 2016-11-18 00:52:13]

Description was changed from

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
==========

to

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
TBR=tsepez@chromium.org
==========

[msw, 2016-11-18 00:52:13]

msw@chromium.org changed reviewers:
+ tsepez@chromium.org

[msw, 2016-11-18 00:52:49]

+TBR Tom for mojom string constant removal OWNERS review.

[msw, 2016-11-18 00:52:54]

The CQ bit was checked by msw@chromium.org

[msw, 2016-11-18 00:52:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2514473003/#ps60001
(title: "Add owership comments.")

[commit-bot: I haz the power, 2016-11-18 00:54:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 03:56:18]

Description was changed from

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
TBR=tsepez@chromium.org
==========

[commit-bot: I haz the power, 2016-11-18 03:56:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-18 04:01:01]

Description was changed from

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
Replace IDR window property use with gfx::ImageSkia icons.

Chrome shouldn't rely on ash to load images by IDR.
Consolidate codepaths/properties for window icons.

NOTE: Regresses Settings & Task Manager shelf icons in mash.
(this will be resolved once we're using aura::Windows in mash)

BUG=NONE
TEST=No Settings or Task Manager window/shelf icon regressions.
R=jamescook@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/d3ddd7adb380ba163b9a598c4a12c85eb4fd30e0
Cr-Commit-Position: refs/heads/master@{#433082}
==========

[commit-bot: I haz the power, 2016-11-18 04:01:02]

Patchset 4 (id:??) landed as
https://crrev.com/d3ddd7adb380ba163b9a598c4a12c85eb4fd30e0
Cr-Commit-Position: refs/heads/master@{#433082}