Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3024)

Unified Diff: ash/mus/bridge/wm_window_mus.cc

Issue 2514473003: Replace IDR window property use with gfx::ImageSkia icons. (Closed)
Patch Set: Add owership comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/wm_window_property.h ('k') | ash/mus/window_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/bridge/wm_window_mus.cc
diff --git a/ash/mus/bridge/wm_window_mus.cc b/ash/mus/bridge/wm_window_mus.cc
index d327bc70be53b11be3624374275fd2cfe5d39c04..c0fb3b75a2ce673c9ada507f174c53c0ba327c09 100644
--- a/ash/mus/bridge/wm_window_mus.cc
+++ b/ash/mus/bridge/wm_window_mus.cc
@@ -107,8 +107,6 @@ WmWindowProperty WmWindowPropertyFromUI(const std::string& ui_window_key) {
return WmWindowProperty::ALWAYS_ON_TOP;
if (ui_window_key == ui::mojom::WindowManager::kExcludeFromMru_Property)
return WmWindowProperty::EXCLUDE_FROM_MRU;
- if (ui_window_key == ui::mojom::WindowManager::kShelfIconResourceId_Property)
- return WmWindowProperty::SHELF_ICON_RESOURCE_ID;
if (ui_window_key == ui::mojom::WindowManager::kShelfItemType_Property)
return WmWindowProperty::SHELF_ITEM_TYPE;
return WmWindowProperty::INVALID_PROPERTY;
@@ -425,18 +423,6 @@ int WmWindowMus::GetIntProperty(WmWindowProperty key) {
return static_cast<int>(ui::MODAL_TYPE_NONE);
}
- if (key == WmWindowProperty::SHELF_ICON_RESOURCE_ID) {
- if (window_->HasSharedProperty(
- ui::mojom::WindowManager::kShelfIconResourceId_Property)) {
- return window_->GetSharedProperty<int>(
- ui::mojom::WindowManager::kShelfIconResourceId_Property);
- }
- // Mash provides a default shelf icon image.
- // TODO(msw): Support icon resource ids and bitmaps:
- // mojo::Array<uint8_t> app_icon = GetWindowAppIcon(window_);
- return IDR_DEFAULT_FAVICON;
- }
-
if (key == WmWindowProperty::SHELF_ID) {
if (window_->HasSharedProperty(
ui::mojom::WindowManager::kShelfId_Property)) {
@@ -469,12 +455,6 @@ int WmWindowMus::GetIntProperty(WmWindowProperty key) {
}
void WmWindowMus::SetIntProperty(WmWindowProperty key, int value) {
- if (key == WmWindowProperty::SHELF_ICON_RESOURCE_ID) {
- window_->SetSharedProperty<int>(
- ui::mojom::WindowManager::kShelfIconResourceId_Property, value);
- return;
- }
-
if (key == WmWindowProperty::SHELF_ID) {
window_->SetSharedProperty<int>(ui::mojom::WindowManager::kShelfId_Property,
value);
« no previous file with comments | « ash/common/wm_window_property.h ('k') | ash/mus/window_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698