Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Unified Diff: ash/aura/wm_window_aura.cc

Issue 2514473003: Replace IDR window property use with gfx::ImageSkia icons. (Closed)
Patch Set: Add owership comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/shelf/shelf_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/aura/wm_window_aura.cc
diff --git a/ash/aura/wm_window_aura.cc b/ash/aura/wm_window_aura.cc
index ac850aa00ca98e1860816e4af413187743622985..ce5e50bbe6ff74a60a9ff1f557bfc2e88004a93e 100644
--- a/ash/aura/wm_window_aura.cc
+++ b/ash/aura/wm_window_aura.cc
@@ -333,9 +333,6 @@ int WmWindowAura::GetIntProperty(WmWindowProperty key) {
if (key == WmWindowProperty::MODAL_TYPE)
return window_->GetProperty(aura::client::kModalKey);
- if (key == WmWindowProperty::SHELF_ICON_RESOURCE_ID)
- return window_->GetProperty(kShelfIconResourceIdKey);
-
if (key == WmWindowProperty::SHELF_ID)
return window_->GetProperty(kShelfIDKey);
@@ -350,10 +347,6 @@ int WmWindowAura::GetIntProperty(WmWindowProperty key) {
}
void WmWindowAura::SetIntProperty(WmWindowProperty key, int value) {
- if (key == WmWindowProperty::SHELF_ICON_RESOURCE_ID) {
- window_->SetProperty(kShelfIconResourceIdKey, value);
- return;
- }
if (key == WmWindowProperty::SHELF_ID) {
window_->SetProperty(kShelfIDKey, value);
return;
@@ -884,8 +877,6 @@ void WmWindowAura::OnWindowPropertyChanged(aura::Window* window,
wm_property = WmWindowProperty::EXCLUDE_FROM_MRU;
} else if (key == aura::client::kModalKey) {
wm_property = WmWindowProperty::MODAL_TYPE;
- } else if (key == kShelfIconResourceIdKey) {
- wm_property = WmWindowProperty::SHELF_ICON_RESOURCE_ID;
} else if (key == kShelfIDKey) {
wm_property = WmWindowProperty::SHELF_ID;
} else if (key == kShelfItemTypeKey) {
« no previous file with comments | « no previous file | ash/common/shelf/shelf_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698