Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2514453003: Revert of [android] Stop using isolate.py for data dependency management. (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [android] Stop using isolate.py for data dependency management. (patchset #9 id:160001 of https://codereview.chromium.org/2492123002/ ) Reason for revert: Breaks the blink bot, e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/57103 Original issue's description: > [android] Stop using isolate.py for data dependency management. > > BUG=663110 > > Committed: https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3 > Cr-Commit-Position: refs/heads/master@{#432940} TBR=agrieve@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663110 Committed: https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74 Cr-Commit-Position: refs/heads/master@{#433020}

Patch Set 1 #

Patch Set 2 : manual rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+829 lines, -309 lines) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/PRESUBMIT.py View 1 1 chunk +0 lines, -1 line 0 comments Download
A build/android/gn/generate_isolate.py View 1 chunk +120 lines, -0 lines 0 comments Download
M build/android/gyp/create_test_runner_script.py View 1 2 chunks +0 lines, -4 lines 0 comments Download
M build/android/pylib/base/test_instance_factory.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 5 chunks +24 lines, -9 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 6 chunks +27 lines, -11 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 3 chunks +7 lines, -10 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 chunks +9 lines, -1 line 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 1 2 chunks +0 lines, -10 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run_test.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D build/android/pylib/utils/device_dependencies.py View 1 chunk +0 lines, -104 lines 0 comments Download
D build/android/pylib/utils/device_dependencies_test.py View 1 chunk +0 lines, -56 lines 0 comments Download
A build/android/pylib/utils/isolator.py View 1 chunk +192 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 1 2 chunks +4 lines, -12 lines 0 comments Download
M build/android/test_runner.pydeps View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 4 chunks +56 lines, -27 lines 0 comments Download
M build/config/android/rules.gni View 1 2 chunks +21 lines, -9 lines 0 comments Download
A build/secondary/tools/swarming_client/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A build/secondary/tools/swarming_client/isolate.pydeps View 1 chunk +298 lines, -0 lines 0 comments Download
M testing/test.gni View 1 5 chunks +49 lines, -23 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
jbudorick
Created Revert of [android] Stop using isolate.py for data dependency management.
4 years, 1 month ago (2016-11-17 23:51:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514453003/1
4 years, 1 month ago (2016-11-17 23:53:29 UTC) #3
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-17 23:54:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514453003/260001
4 years, 1 month ago (2016-11-18 00:07:55 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-18 00:08:53 UTC) #9
jbudorick
On 2016/11/18 00:08:53, commit-bot: I haz the power wrote: > Failed to apply the patch. ...
4 years, 1 month ago (2016-11-18 01:43:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514453003/260001
4 years, 1 month ago (2016-11-18 01:44:21 UTC) #13
jbudorick
On 2016/11/18 01:43:00, jbudorick wrote: > On 2016/11/18 00:08:53, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-11-18 01:53:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514453003/260001
4 years, 1 month ago (2016-11-18 02:00:09 UTC) #18
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 1 month ago (2016-11-18 02:05:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514453003/260001
4 years, 1 month ago (2016-11-18 02:11:27 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:260001)
4 years, 1 month ago (2016-11-18 02:12:54 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 02:14:29 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74
Cr-Commit-Position: refs/heads/master@{#433020}

Powered by Google App Engine
This is Rietveld 408576698