Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: PRESUBMIT.py

Issue 2514453003: Revert of [android] Stop using isolate.py for data dependency management. (Closed)
Patch Set: manual rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 ) 362 )
363 363
364 364
365 _ANDROID_SPECIFIC_PYDEPS_FILES = [ 365 _ANDROID_SPECIFIC_PYDEPS_FILES = [
366 'build/android/test_runner.pydeps', 366 'build/android/test_runner.pydeps',
367 'net/tools/testserver/testserver.pydeps', 367 'net/tools/testserver/testserver.pydeps',
368 ] 368 ]
369 369
370 370
371 _GENERIC_PYDEPS_FILES = [ 371 _GENERIC_PYDEPS_FILES = [
372 'build/secondary/tools/swarming_client/isolate.pydeps',
372 ] 373 ]
373 374
374 375
375 _ALL_PYDEPS_FILES = _ANDROID_SPECIFIC_PYDEPS_FILES + _GENERIC_PYDEPS_FILES 376 _ALL_PYDEPS_FILES = _ANDROID_SPECIFIC_PYDEPS_FILES + _GENERIC_PYDEPS_FILES
376 377
377 378
378 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): 379 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
379 """Attempts to prevent use of functions intended only for testing in 380 """Attempts to prevent use of functions intended only for testing in
380 non-testing code. For now this is just a best-effort implementation 381 non-testing code. For now this is just a best-effort implementation
381 that ignores header files and may have some false positives. A 382 that ignores header files and may have some false positives. A
(...skipping 1924 matching lines...) Expand 10 before | Expand all | Expand 10 after
2306 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2307 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2307 input_api, 2308 input_api,
2308 output_api, 2309 output_api,
2309 json_url='http://chromium-status.appspot.com/current?format=json')) 2310 json_url='http://chromium-status.appspot.com/current?format=json'))
2310 2311
2311 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2312 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2312 input_api, output_api)) 2313 input_api, output_api))
2313 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2314 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2314 input_api, output_api)) 2315 input_api, output_api))
2315 return results 2316 return results
OLDNEW
« no previous file with comments | « no previous file | build/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698