Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4509)

Unified Diff: build/config/android/rules.gni

Issue 2514453003: Revert of [android] Stop using isolate.py for data dependency management. (Closed)
Patch Set: manual rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/secondary/tools/swarming_client/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 97872fcee1b353569b10e967ad451adb4566bca4..7e634a7a6dc57026d0c831fdaa0ff10a4e400856 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -2260,23 +2260,36 @@ if (enable_java_templates) {
template("instrumentation_test_apk") {
testonly = true
_apk_target_name = "${target_name}__apk"
+ _gen_isolate_target_name = "${target_name}__isolate"
_test_runner_target_name = "${target_name}__test_runner_script"
_install_script_name = "install_$target_name"
- test_runner_script(_test_runner_target_name) {
+ _target_dir_name = get_label_info(":$target_name", "dir")
+ _device_isolate_path = "$root_out_dir/gen.runtime/$_target_dir_name/$target_name.device.isolate"
+ device_isolate(_gen_isolate_target_name) {
forward_variables_from(invoker,
[
- "additional_apks",
- "apk_under_test",
"data",
"data_deps",
"deps",
- "ignore_all_data_deps",
"public_deps",
])
+ output = _device_isolate_path
+ }
+
+ test_runner_script(_test_runner_target_name) {
+ forward_variables_from(invoker,
+ [
+ "additional_apks",
+ "apk_under_test",
+ ])
test_name = invoker.target_name
test_type = "instrumentation"
apk_target = ":$_apk_target_name"
+ isolate_file = _device_isolate_path
+ deps = [
+ ":$_gen_isolate_target_name",
+ ]
}
test_runner_script("${_test_runner_target_name}_incremental") {
@@ -2284,16 +2297,15 @@ if (enable_java_templates) {
[
"additional_apks",
"apk_under_test",
- "data",
- "data_deps",
- "deps",
- "ignore_all_data_deps",
- "public_deps",
])
test_name = "${invoker.target_name}_incremental"
test_type = "instrumentation"
apk_target = ":$_apk_target_name"
incremental_install = true
+ isolate_file = _device_isolate_path
+ deps = [
+ ":$_gen_isolate_target_name",
+ ]
}
android_apk(_apk_target_name) {
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/secondary/tools/swarming_client/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698