Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2514453002: [ic] Pass name to Runtime::kLoadGlobal_Miss and _Slow. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Pass name to Runtime::kLoadGlobal_Miss and _Slow. This is a next step towards removing names table from type feedback metadata. BUG=chromium:576312, v8:5561 Committed: https://crrev.com/f7723ff512a51c56a93f83564ac44b74debc68bc Cr-Commit-Position: refs/heads/master@{#41111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M src/builtins/builtins-handler.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/ic/accessor-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 6 chunks +10 lines, -23 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-17 15:31:38 UTC) #4
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-17 18:05:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514453002/1
4 years, 1 month ago (2016-11-18 14:19:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 14:21:52 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 14:22:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7723ff512a51c56a93f83564ac44b74debc68bc
Cr-Commit-Position: refs/heads/master@{#41111}

Powered by Google App Engine
This is Rietveld 408576698