Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2507143003: [ic] Pass globals' names to Runtime::kDeclareGlobals. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Pass globals' names to Runtime::kDeclareGlobals. This is a next step towards removing names table from type feedback metadata. BUG=chromium:576312, v8:5561 Committed: https://crrev.com/cfd1dd2f959e833cc524eedccc6041a92db632bf Cr-Commit-Position: refs/heads/master@{#41106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -43 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 6 chunks +29 lines, -17 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +11 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
Igor Sheludko
Michi, PTAL at compiler and interpreter Jakob, PTAL at the rest
4 years, 1 month ago (2016-11-17 15:30:20 UTC) #6
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-17 17:22:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507143003/20001
4 years, 1 month ago (2016-11-18 07:54:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28842)
4 years, 1 month ago (2016-11-18 07:58:44 UTC) #13
Michael Starzinger
LGTM.
4 years, 1 month ago (2016-11-18 10:01:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507143003/20001
4 years, 1 month ago (2016-11-18 12:46:57 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-18 12:58:31 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 12:58:50 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfd1dd2f959e833cc524eedccc6041a92db632bf
Cr-Commit-Position: refs/heads/master@{#41106}

Powered by Google App Engine
This is Rietveld 408576698