Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: src/builtins/builtins-handler.cc

Issue 2514453002: [ic] Pass name to Runtime::kLoadGlobal_Miss and _Slow. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/accessor-assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins-utils.h" 5 #include "src/builtins/builtins-utils.h"
6 #include "src/builtins/builtins.h" 6 #include "src/builtins/builtins.h"
7 #include "src/ic/accessor-assembler.h" 7 #include "src/ic/accessor-assembler.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/keyed-store-generic.h" 10 #include "src/ic/keyed-store-generic.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 void Builtins::Generate_KeyedStoreIC_Slow(MacroAssembler* masm) { 49 void Builtins::Generate_KeyedStoreIC_Slow(MacroAssembler* masm) {
50 KeyedStoreIC::GenerateSlow(masm); 50 KeyedStoreIC::GenerateSlow(masm);
51 } 51 }
52 52
53 void Builtins::Generate_LoadGlobalIC_Miss(compiler::CodeAssemblerState* state) { 53 void Builtins::Generate_LoadGlobalIC_Miss(compiler::CodeAssemblerState* state) {
54 typedef compiler::Node Node; 54 typedef compiler::Node Node;
55 typedef LoadGlobalWithVectorDescriptor Descriptor; 55 typedef LoadGlobalWithVectorDescriptor Descriptor;
56 CodeStubAssembler assembler(state); 56 CodeStubAssembler assembler(state);
57 57
58 Node* name = assembler.Parameter(Descriptor::kName);
58 Node* slot = assembler.Parameter(Descriptor::kSlot); 59 Node* slot = assembler.Parameter(Descriptor::kSlot);
59 Node* vector = assembler.Parameter(Descriptor::kVector); 60 Node* vector = assembler.Parameter(Descriptor::kVector);
60 Node* context = assembler.Parameter(Descriptor::kContext); 61 Node* context = assembler.Parameter(Descriptor::kContext);
61 62
62 assembler.TailCallRuntime(Runtime::kLoadGlobalIC_Miss, context, slot, vector); 63 assembler.TailCallRuntime(Runtime::kLoadGlobalIC_Miss, context, name, slot,
64 vector);
63 } 65 }
64 66
65 void Builtins::Generate_LoadGlobalIC_Slow(compiler::CodeAssemblerState* state) { 67 void Builtins::Generate_LoadGlobalIC_Slow(compiler::CodeAssemblerState* state) {
66 typedef compiler::Node Node; 68 typedef compiler::Node Node;
67 typedef LoadGlobalWithVectorDescriptor Descriptor; 69 typedef LoadGlobalWithVectorDescriptor Descriptor;
68 CodeStubAssembler assembler(state); 70 CodeStubAssembler assembler(state);
69 71
70 Node* slot = assembler.Parameter(Descriptor::kSlot); 72 Node* name = assembler.Parameter(Descriptor::kName);
71 Node* vector = assembler.Parameter(Descriptor::kVector);
72 Node* context = assembler.Parameter(Descriptor::kContext); 73 Node* context = assembler.Parameter(Descriptor::kContext);
73 74
74 assembler.TailCallRuntime(Runtime::kLoadGlobalIC_Slow, context, slot, vector); 75 assembler.TailCallRuntime(Runtime::kLoadGlobalIC_Slow, context, name);
75 } 76 }
76 77
77 void Builtins::Generate_LoadIC_Getter_ForDeopt(MacroAssembler* masm) { 78 void Builtins::Generate_LoadIC_Getter_ForDeopt(MacroAssembler* masm) {
78 NamedLoadHandlerCompiler::GenerateLoadViaGetterForDeopt(masm); 79 NamedLoadHandlerCompiler::GenerateLoadViaGetterForDeopt(masm);
79 } 80 }
80 81
81 void Builtins::Generate_LoadIC_Miss(compiler::CodeAssemblerState* state) { 82 void Builtins::Generate_LoadIC_Miss(compiler::CodeAssemblerState* state) {
82 typedef compiler::Node Node; 83 typedef compiler::Node Node;
83 typedef LoadWithVectorDescriptor Descriptor; 84 typedef LoadWithVectorDescriptor Descriptor;
84 CodeStubAssembler assembler(state); 85 CodeStubAssembler assembler(state);
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 Generate_StoreIC_Slow(state, SLOPPY); 159 Generate_StoreIC_Slow(state, SLOPPY);
159 } 160 }
160 161
161 void Builtins::Generate_StoreIC_SlowStrict( 162 void Builtins::Generate_StoreIC_SlowStrict(
162 compiler::CodeAssemblerState* state) { 163 compiler::CodeAssemblerState* state) {
163 Generate_StoreIC_Slow(state, STRICT); 164 Generate_StoreIC_Slow(state, STRICT);
164 } 165 }
165 166
166 } // namespace internal 167 } // namespace internal
167 } // namespace v8 168 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/ic/accessor-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698