[css-grid] Avoid double loop in positioned objects layout

third_party/WebKit/Source/core/layout/LayoutBlock.h

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index 6e9ae47c0298e0fe3cf4bacf1e7082e8c5c1eb2b..e5a53e0ace7cf9d6a6866e04e2b722e81617d3db 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -358,9 +358,11 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
     ForcedLayoutAfterContainingBlockMoved
   };
 
-  virtual void layoutPositionedObjects(
-      bool relayoutChildren,
-      PositionedLayoutBehavior = DefaultLayout);
+  void layoutPositionedObjects(bool relayoutChildren,
+                               PositionedLayoutBehavior = DefaultLayout);
+  virtual void layoutPositionedObject(LayoutBox*,

[jfernandez, 2016/11/18 16:18:22]

I think it'd be better to keep layoutPositionedObjects as virtual, so we can
re-implement it in the subclasses and call layoutPositionedObject when needed. I
understood from the rest of the patch that you don't want to change the behavior
of layoutPositionedObject, but doing some extra operations.

My suggestion tries to avoid calling n-times to the virtual function, so we can
do it just once an re-implement the loop using the new layoutPositionedObject
function, which contains the logic you want to execute.

[Manuel Rego, 2016/11/18 16:39:28]

Good point, I'll keep the previous approach.

+                                      bool relayoutChildren,
+                                      PositionedLayoutBehavior info);
   void markFixedPositionObjectForLayoutIfNeeded(LayoutObject* child,
                                                 SubtreeLayoutScope&);