third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2513953002: [css-grid] Avoid double loop in positioned objects layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2513953002: [css-grid] Avoid double loop in positioned objects layout (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index d563e877d53e887141143c84b868910572ef1168..304fc0aa52a3b620ffac7fef9b5e5f2c662f0c83 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -183,7 +183,8 @@ class LayoutGrid final : public LayoutBlock {

void layoutGridItems(GridSizingData&);

void prepareChildForPositionedLayout(LayoutBox&);

- void layoutPositionedObjects(

+ void layoutPositionedObject(

jfernandez 2016/11/18 16:18:22 Better keep overriding the layoutPositionedObjects

+ LayoutBox*,

bool relayoutChildren,

PositionedLayoutBehavior = DefaultLayout) override;

void offsetAndBreadthForPositionedChild(const LayoutBox&,