[css-grid] Avoid double loop in positioned objects layout

third_party/WebKit/Source/core/layout/LayoutBlock.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
  *               All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 340 matching lines @@
   void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&);
 
   void layout() override;
 
   enum PositionedLayoutBehavior {
     DefaultLayout,
     LayoutOnlyFixedPositionedObjects,
     ForcedLayoutAfterContainingBlockMoved
   };
 
-  virtual void layoutPositionedObjects(
-      bool relayoutChildren,
-      PositionedLayoutBehavior = DefaultLayout);
+  void layoutPositionedObjects(bool relayoutChildren,
+                               PositionedLayoutBehavior = DefaultLayout);
+  virtual void layoutPositionedObject(LayoutBox*,

[jfernandez, 2016/11/18 16:18:22]

I think it'd be better to keep layoutPositionedObjects as virtual, so we can
re-implement it in the subclasses and call layoutPositionedObject when needed. I
understood from the rest of the patch that you don't want to change the behavior
of layoutPositionedObject, but doing some extra operations.

My suggestion tries to avoid calling n-times to the virtual function, so we can
do it just once an re-implement the loop using the new layoutPositionedObject
function, which contains the logic you want to execute.

[Manuel Rego, 2016/11/18 16:39:28]

Good point, I'll keep the previous approach.

+                                      bool relayoutChildren,
+                                      PositionedLayoutBehavior info);
   void markFixedPositionObjectForLayoutIfNeeded(LayoutObject* child,
                                                 SubtreeLayoutScope&);
 
   LayoutUnit marginIntrinsicLogicalWidthForChild(const LayoutBox& child) const;
 
   int beforeMarginInLineDirection(LineDirectionMode) const;
 
   void paint(const PaintInfo&, const LayoutPoint&) const override;
 
  public:
@@ skipping 192 matching lines @@
   // TODO(lunalu): Temporary in order to ensure compatibility with existing
   // layout test results.
   virtual void adjustChildDebugRect(LayoutRect&) const {}
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
 
 }  // namespace blink
 
 #endif  // LayoutBlock_h