DevTools: introduce perf monitor actions w/ time budget for violations that are event handlers.

DevTools: introduce perf monitor actions w/ time budget for violations that are event handlers.

BUG=662497
Committed: https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6
Cr-Commit-Position: refs/heads/master@{#432771}

[pfeldman, 2016-11-17 01:58:00]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-11-17 02:16:00]

lgtm

https://codereview.chromium.org/2513483002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right):

https://codereview.chromium.org/2513483002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:24:
m_performanceMonitor(PerformanceMonitor::instrumentingMonitor(context)),
nit: extract into a private default constructor along with the call to start()
and call delegated constructor.

[pfeldman, 2016-11-17 02:28:22]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-11-17 02:28:22]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2513483002/#ps60001
(title: "expose locations instead of functions")

[commit-bot: I haz the power, 2016-11-17 02:29:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2016-11-17 02:42:15]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-11-17 02:42:16]

https://codereview.chromium.org/2513483002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right):

https://codereview.chromium.org/2513483002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:30:
PerformanceMonitor::HandlerCall::HandlerCall(ExecutionContext* context,
Looks hacky.
How about making a base class, e.g. DurationProbe that would implement the
duration check logic.

https://codereview.chromium.org/2513483002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:52: if (time <
threshold)
<=

https://codereview.chromium.org/2513483002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:63:
SourceLocation::fromFunction(m_scheduledAction->handlerFunction());
Can you make the action just return the location rather than handlerFunction?

[commit-bot: I haz the power, 2016-11-17 04:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:31:07]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[pfeldman, 2016-11-17 05:40:07]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:40:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 05:47:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 05:49:50]

Description was changed from

==========
DevTools: introduce perf monitor actions w/ time budget for violations that are
event handlers.

BUG=662497
==========

to

==========
DevTools: introduce perf monitor actions w/ time budget for violations that are
event handlers.

BUG=662497

Committed: https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6
Cr-Commit-Position: refs/heads/master@{#432771}
==========

[commit-bot: I haz the power, 2016-11-17 05:49:51]

Patchset 4 (id:??) landed as
https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6
Cr-Commit-Position: refs/heads/master@{#432771}