third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp - Issue 2513483002: DevTools: introduce perf monitor actions w/ time budget for violations that are event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

Issue 2513483002: DevTools: introduce perf monitor actions w/ time budget for violations that are event handlers. (Closed)

Patch Set: expose locations instead of functions Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

index afc43d59f3b1afbe7be35f85275c3fb5d047ba36..79b829ee754791055b807876614e49c488a17437 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

@@ -173,6 +173,10 @@ static PerformanceMonitor::Violation parseViolation(const String& name) {

return PerformanceMonitor::kBlockedEvent;

if (name == ViolationSetting::NameEnum::BlockedParser)

return PerformanceMonitor::kBlockedParser;

+ if (name == ViolationSetting::NameEnum::Handler)

+ return PerformanceMonitor::kHandler;

+ if (name == ViolationSetting::NameEnum::RecurringHandler)

+ return PerformanceMonitor::kRecurringHandler;

return PerformanceMonitor::kAfterLast;

}