third_party/WebKit/Source/core/frame/DOMTimer.cpp - Issue 2513483002: DevTools: introduce perf monitor actions w/ time budget for violations that are event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimer.cpp

Issue 2513483002: DevTools: introduce perf monitor actions w/ time budget for violations that are event handlers. (Closed)

Patch Set: expose locations instead of functions Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMTimer.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMTimer.cpp b/third_party/WebKit/Source/core/frame/DOMTimer.cpp

index 9e06504bf8f90d19c2620a29374a76f02790dcdd..30fe1c046957604f6eb63a6c780979c91333e446 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimer.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMTimer.cpp

@@ -27,6 +27,7 @@

#include "core/frame/DOMTimer.h"

#include "core/dom/ExecutionContext.h"

+#include "core/frame/PerformanceMonitor.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/InspectorTraceEvents.h"

#include "platform/tracing/TraceEvent.h"

@@ -133,6 +134,7 @@ void DOMTimer::fired() {

TRACE_EVENT1("devtools.timeline", "TimerFire", "data",

InspectorTimerFireEvent::data(context, m_timeoutID));

+ PerformanceMonitor::HandlerCall handlerCall(context, m_action);

InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(

context, "timerFired", false);

InspectorInstrumentation::AsyncTask asyncTask(context, this);