[ImageResource 0a] Do not notify ResourceClient/ImageResourceObserver of finish twice

Do not notify ResourceClient/ImageResourceObserver of finish twice

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598
Committed: https://crrev.com/18a8d7074c9f0c8e2c3fff36b3a021cdd3a06477
Cr-Commit-Position: refs/heads/master@{#434952}

[hiroshige, 2016-11-22 10:00:22]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 10:00:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-22 10:01:21]

Description was changed from

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

BUG=
==========

to

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

BUG=
==========

[commit-bot: I haz the power, 2016-11-22 11:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 11:50:59]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-11-22 11:51:26]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 11:51:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-22 11:58:22]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 11:58:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 13:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 13:40:30]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-22 18:41:45]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 18:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 19:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 19:13:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[hiroshige, 2016-11-25 04:56:28]

Description was changed from

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

BUG=
==========

to

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

BUG=668598
==========

[hiroshige, 2016-11-25 04:56:28]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[hiroshige, 2016-11-25 04:56:57]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 04:57:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 07:01:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 07:01:43]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-25 10:07:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 10:07:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 11:26:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 11:26:50]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-28 06:12:33]

Description was changed from

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

BUG=668598
==========

to

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598
==========

[hiroshige, 2016-11-28 06:14:03]

PTAL.

[hiroshige, 2016-11-28 06:45:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 06:45:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 09:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 09:23:20]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-29 02:23:30]

https://codereview.chromium.org/2513413008/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/Resource.h (left):

https://codereview.chromium.org/2513413008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/Resource.h:342: void
notifyClientsInternal(MarkFinishedOption);
Is it a good idea to merge this function to checkNotify again?

[hiroshige, 2016-11-29 07:05:23]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 07:05:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-29 07:54:31]

https://codereview.chromium.org/2513413008/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/Resource.h (left):

https://codereview.chromium.org/2513413008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/Resource.h:342: void
notifyClientsInternal(MarkFinishedOption);
On 2016/11/29 02:23:30, yhirano wrote:
> Is it a good idea to merge this function to checkNotify again?

Done.

[yhirano, 2016-11-29 07:56:02]

lgtm

[commit-bot: I haz the power, 2016-11-29 08:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 08:36:20]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-29 09:14:19]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:14:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-29 10:28:48]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-11-29 10:28:53]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-29 10:28:53]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2513413008/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-29 10:29:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 10:39:11]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1480415333631360,
"parent_rev": "b0f96ee3006230800fa9fdf88f4b0cacc50559f7", "commit_rev":
"2f622ebcdc4e23c5a555abd95f4a12f6a368ed5b"}

[commit-bot: I haz the power, 2016-11-29 10:39:34]

Description was changed from

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598
==========

to

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598
==========

[commit-bot: I haz the power, 2016-11-29 10:39:35]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-11-29 10:41:16]

Description was changed from

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598
==========

to

==========
Do not notify ResourceClient/ImageResourceObserver of finish twice

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598

Committed: https://crrev.com/18a8d7074c9f0c8e2c3fff36b3a021cdd3a06477
Cr-Commit-Position: refs/heads/master@{#434952}
==========

[commit-bot: I haz the power, 2016-11-29 10:41:18]

Patchset 9 (id:??) landed as
https://crrev.com/18a8d7074c9f0c8e2c3fff36b3a021cdd3a06477
Cr-Commit-Position: refs/heads/master@{#434952}