[ImageResource 0a] Do not notify ResourceClient/ImageResourceObserver of finish twice

third_party/WebKit/Source/core/fetch/Resource.h

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
     rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 320 matching lines @@
   virtual void onMemoryDump(WebMemoryDumpLevelOfDetail,
                             WebProcessMemoryDump*) const;
 
   static const char* resourceTypeToString(Type, const FetchInitiatorInfo&);
 
  protected:
   Resource(const ResourceRequest&, Type, const ResourceLoaderOptions&);
 
   virtual void checkNotify();
 
-  enum class MarkFinishedOption { ShouldMarkFinished, DoNotMarkFinished };
-  void notifyClientsInternal(MarkFinishedOption);

[yhirano, 2016/11/29 02:23:30]

Is it a good idea to merge this function to checkNotify again?

[hiroshige, 2016/11/29 07:54:31]

Done.

+  void notifyClientsInternal();
   void markClientFinished(ResourceClient*);
 
   virtual bool hasClientsOrObservers() const {
     return !m_clients.isEmpty() || !m_clientsAwaitingCallback.isEmpty() ||
            !m_finishedClients.isEmpty();
   }
   virtual void destroyDecodedDataForFailedRevalidation() {}
 
   void setEncodedSize(size_t);
   void setDecodedSize(size_t);
@@ skipping 141 matching lines @@
 };
 
 #define DEFINE_RESOURCE_TYPE_CASTS(typeName)                   \
   DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource,    \
                     resource->getType() == Resource::typeName, \
                     resource.getType() == Resource::typeName);
 
 }  // namespace blink
 
 #endif