Do not rely on broken images in http/tests/multipart/ tests

Do not rely on broken images in http/tests/multipart/ tests

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598
Committed: https://crrev.com/0292701c1facba4d2162eaff216ba10065ca482f
Cr-Commit-Position: refs/heads/master@{#434947}

[hiroshige, 2016-03-29 00:59:07]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 00:59:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840933002/1

[commit-bot: I haz the power, 2016-03-29 02:10:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 02:10:33]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-22 11:49:31]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 11:49:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-22 11:57:51]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 11:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 14:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 14:53:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-11-22 18:37:08]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 18:37:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 19:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 19:04:29]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[hiroshige, 2016-11-25 04:56:43]

Description was changed from

==========
Do not rely on broken images in http/tests/multipart/ tests

BUG=
==========

to

==========
Do not rely on broken images in http/tests/multipart/ tests

BUG=668598
==========

[hiroshige, 2016-11-25 04:56:44]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[hiroshige, 2016-11-25 04:56:54]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 04:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 06:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 06:39:54]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-25 09:27:56]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 09:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-25 09:51:01]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 09:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-25 10:06:01]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 10:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 13:35:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 13:35:45]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-28 06:17:51]

Description was changed from

==========
Do not rely on broken images in http/tests/multipart/ tests

BUG=668598
==========

to

==========
Do not rely on broken images in http/tests/multipart/ tests

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598
==========

[hiroshige, 2016-11-28 06:17:57]

PTAL.

[hiroshige, 2016-11-28 06:42:27]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 06:42:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 09:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 09:20:04]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-29 01:59:39]

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload1.html
(right):

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload1.html:13:
assert_true(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=1"),
"The image should be loading before window.stop().");
Is it a good idea to have a constant for the url in this function?

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload1.html:18:
assert_false(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=1"),
"The image should not be loading before window.stop().");
after

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload2.html
(right):

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload2.html:13:
assert_true(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=2"),
"The image should be loading before window.stop().");
Is it a good idea to have a constant for the url in this function?

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload2.html:18:
assert_false(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=2"),
"The image should not be loading before window.stop().");
after

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html
(right):

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html:11:
assert_true(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png"),
"The image should be loading before window.stop().");
Is it a good idea to have a constant for the url in this function?

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html:16:
assert_false(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png"),
"The image should not be loading before window.stop().");
after

[hiroshige, 2016-11-29 07:04:00]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 07:04:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-29 07:57:00]

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload1.html
(right):

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload1.html:13:
assert_true(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=1"),
"The image should be loading before window.stop().");
On 2016/11/29 01:59:39, yhirano wrote:
> Is it a good idea to have a constant for the url in this function?

Done.

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload1.html:18:
assert_false(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=1"),
"The image should not be loading before window.stop().");
On 2016/11/29 01:59:39, yhirano wrote:
> after

Done.

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload2.html
(right):

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload2.html:13:
assert_true(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=2"),
"The image should be loading before window.stop().");
On 2016/11/29 01:59:39, yhirano wrote:
> Is it a good idea to have a constant for the url in this function?

Done.

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading-after-onload2.html:18:
assert_false(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png&label=2"),
"The image should not be loading before window.stop().");
On 2016/11/29 01:59:39, yhirano wrote:
> after

Done.

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html
(right):

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html:11:
assert_true(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png"),
"The image should be loading before window.stop().");
On 2016/11/29 01:59:39, yhirano wrote:
> Is it a good idea to have a constant for the url in this function?

Done.

https://codereview.chromium.org/1840933002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html:16:
assert_false(internals.isLoading("resources/multipart.php?interval=1&loop=1&img1=2x2-green.png&img2=abe.png"),
"The image should not be loading before window.stop().");
On 2016/11/29 01:59:39, yhirano wrote:
> after

Done.

[yhirano, 2016-11-29 07:59:16]

lgtm

[commit-bot: I haz the power, 2016-11-29 08:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 08:23:54]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-29 09:00:25]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:00:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 09:09:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:09:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hiroshige, 2016-11-29 09:13:04]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:13:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-29 09:14:46]

hiroshige@chromium.org changed reviewers:
+ kouhei@chromium.org

[hiroshige, 2016-11-29 09:14:46]

+kouhei, PTAL as core/ OWNER.

[kouhei (in TOK), 2016-11-29 09:22:05]

lgtm

[hiroshige, 2016-11-29 10:14:38]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-11-29 10:15:04]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-29 10:15:04]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1840933002/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-29 10:15:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 10:26:22]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1480414504099140,
"parent_rev": "7edca0bc39ce412802facd700fa44d90125ba47b", "commit_rev":
"014ac951ce3f8245c478c3d72ad0571326de281a"}

[commit-bot: I haz the power, 2016-11-29 10:26:51]

Description was changed from

==========
Do not rely on broken images in http/tests/multipart/ tests

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598
==========

to

==========
Do not rely on broken images in http/tests/multipart/ tests

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598
==========

[commit-bot: I haz the power, 2016-11-29 10:26:53]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-11-29 10:29:04]

Description was changed from

==========
Do not rely on broken images in http/tests/multipart/ tests

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598
==========

to

==========
Do not rely on broken images in http/tests/multipart/ tests

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598

Committed: https://crrev.com/0292701c1facba4d2162eaff216ba10065ca482f
Cr-Commit-Position: refs/heads/master@{#434947}
==========

[commit-bot: I haz the power, 2016-11-29 10:29:07]

Patchset 11 (id:??) landed as
https://crrev.com/0292701c1facba4d2162eaff216ba10065ca482f
Cr-Commit-Position: refs/heads/master@{#434947}