Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2513273002: [test] Add array destructuring micro-benchmarks. (Closed)

Created:
4 years, 1 month ago by Franzi
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add array destructuring micro-benchmarks. Add array pattern destructuring micro-benchmarks. These benchmarks compare a naive ES5 immplementation to an ES6-style implementation that uses destructuring. Adapted from http://kpdecker.github.io/six-speed BUG=v8:5267 Committed: https://crrev.com/f31e80548c97170147e13f6c2deede34bb3dcd16 Cr-Commit-Position: refs/heads/master@{#41126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M test/js-perf-test/SixSpeed.json View 1 chunk +14 lines, -0 lines 0 comments Download
A + test/js-perf-test/SixSpeed/array_destructuring/array_destructuring.js View 3 chunks +8 lines, -11 lines 0 comments Download
A + test/js-perf-test/SixSpeed/array_destructuring/run.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Franzi
ptal
4 years, 1 month ago (2016-11-20 15:30:51 UTC) #3
Benedikt Meurer
LGTM, thanks.
4 years, 1 month ago (2016-11-20 17:33:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513273002/1
4 years, 1 month ago (2016-11-20 19:45:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-20 20:07:31 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-20 20:07:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f31e80548c97170147e13f6c2deede34bb3dcd16
Cr-Commit-Position: refs/heads/master@{#41126}

Powered by Google App Engine
This is Rietveld 408576698