Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2509593004: [test] Add object literal micro-benchmarks. (Closed)

Created:
4 years, 1 month ago by Franzi
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add object literal micro-benchmarks. Add computed property names in object literal micro-benchmarks. Taken from http://kpdecker.github.io/six-speed/ BUG=v8:5622 Committed: https://crrev.com/5b3a893f9eb97fa8fd8ab0dcf6bcfedea2fa2c3b Cr-Commit-Position: refs/heads/master@{#41057}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M test/js-perf-test/SixSpeed.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A test/js-perf-test/SixSpeed/object_literals/object_literals.js View 1 1 chunk +41 lines, -0 lines 0 comments Download
A + test/js-perf-test/SixSpeed/object_literals/run.js View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Franzi
Please take a look. Thanks, Franzi
4 years, 1 month ago (2016-11-16 20:01:09 UTC) #2
Yang
lgtm https://codereview.chromium.org/2509593004/diff/1/test/js-perf-test/SixSpeed.json File test/js-perf-test/SixSpeed.json (right): https://codereview.chromium.org/2509593004/diff/1/test/js-perf-test/SixSpeed.json#newcode13 test/js-perf-test/SixSpeed.json:13: "path": ["SixSpeed/ObjectLiterals"], So, uhm.. bikeshedding. I intended the ...
4 years, 1 month ago (2016-11-16 20:44:30 UTC) #3
Franzi
On 2016/11/16 20:44:30, Yang wrote: > lgtm > > https://codereview.chromium.org/2509593004/diff/1/test/js-perf-test/SixSpeed.json > File test/js-perf-test/SixSpeed.json (right): > ...
4 years, 1 month ago (2016-11-17 05:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509593004/20001
4 years, 1 month ago (2016-11-17 05:31:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 05:53:42 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b3a893f9eb97fa8fd8ab0dcf6bcfedea2fa2c3b
Cr-Commit-Position: refs/heads/master@{#41057}

Powered by Google App Engine
This is Rietveld 408576698