Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2525053002:
[test] Add performance test for closures. (Closed)
Description[test] Add performance test for closures.
Short living closures are very common in Node.js. This benchmark tracks progress
as we move the optimizations that are currently only behind
--mark_shared_functions_for_tier_up to the default settings.
BUG=v8:5512
Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95
Committed: https://crrev.com/82061d6ab3e88ff4f0799ee5b75b2aff8b72bc1c
Cr-Original-Commit-Position: refs/heads/master@{#41246}
Cr-Commit-Position: refs/heads/master@{#41487}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix regex in json file. #Patch Set 3 : Rename tests. #
Messages
Total messages: 32 (20 generated)
Description was changed from ========== [test] Add perf test for closures. Short living closures like the one in the test are very common in Node.js. This benchmark traces progress as we move the optimization that are currently only behind --mark_shared_functions_for_tier_up. BUG=v8:5512 ========== to ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 ==========
franzih@chromium.org changed reviewers: + bmeurer@chromium.org, leszeks@chromium.org
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM, thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479974756077620, "parent_rev":
"c95ac47b7e83193cd59f2f1275e5f2e8e3e01596", "commit_rev":
"1197997ba24fbb821771557dfb4fd6789b759700"}
Message was sent while issue was closed.
Description was changed from ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 ========== to ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 ========== to ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Cr-Commit-Position: refs/heads/master@{#41246} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Cr-Commit-Position: refs/heads/master@{#41246}
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2525053002/diff/1/test/js-perf-test/JSTests.json File test/js-perf-test/JSTests.json (right): https://codereview.chromium.org/2525053002/diff/1/test/js-perf-test/JSTests.j... test/js-perf-test/JSTests.json:97: {"name": "Closures"} I'm not sure if duplicate names work. How would that be unique on the perf dashboard? Also the regexp doesn't match what is printed.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2526163003/ by machenbach@chromium.org. The reason for reverting is: Fails on perf..
Message was sent while issue was closed.
Description was changed from ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Cr-Commit-Position: refs/heads/master@{#41246} ========== to ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Cr-Commit-Position: refs/heads/master@{#41246} ==========
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Fixed regex and test names. PTAL. Thanks, Franzi
Still LGTM! :-)
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480943326428370,
"parent_rev": "33501256751b46e7ab9efa16f024f0ce28445fd2", "commit_rev":
"fc14a87a8b2b02d77ae994130b423b7056072216"}
Message was sent while issue was closed.
Description was changed from ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Cr-Commit-Position: refs/heads/master@{#41246} ========== to ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Cr-Commit-Position: refs/heads/master@{#41246} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Cr-Commit-Position: refs/heads/master@{#41246} ========== to ========== [test] Add performance test for closures. Short living closures are very common in Node.js. This benchmark tracks progress as we move the optimizations that are currently only behind --mark_shared_functions_for_tier_up to the default settings. BUG=v8:5512 Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 Committed: https://crrev.com/82061d6ab3e88ff4f0799ee5b75b2aff8b72bc1c Cr-Original-Commit-Position: refs/heads/master@{#41246} Cr-Commit-Position: refs/heads/master@{#41487} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/82061d6ab3e88ff4f0799ee5b75b2aff8b72bc1c Cr-Commit-Position: refs/heads/master@{#41487} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
