Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2512963002: [debug-wrapper] Migrate more tests (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] Migrate more tests * Fix setting script-scope variables through inspector by internalizing their names. * Reconstruct values of Number, String, and Boolean classes. * Adapt a couple of tests for API restrictions. BUG=v8:5530 Committed: https://crrev.com/facd6b9a4abb8d612d2b21a669dc4c9771945863 Cr-Commit-Position: refs/heads/master@{#41175}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -1387 lines) Patch
M src/debug/debug-scopes.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/debugger/debug/debug-conditional-breakpoints.js View 3 chunks +3 lines, -20 lines 0 comments Download
A + test/debugger/debug/debug-evaluate-shadowed-context.js View 1 chunk +1 line, -1 line 0 comments Download
A test/debugger/debug/debug-function-scopes.js View 1 chunk +191 lines, -0 lines 0 comments Download
A + test/debugger/debug/debug-multiple-breakpoints.js View 3 chunks +11 lines, -24 lines 0 comments Download
A + test/debugger/debug/debug-negative-break-points.js View 2 chunks +14 lines, -15 lines 0 comments Download
A + test/debugger/debug/debug-receiver.js View 2 chunks +1 line, -3 lines 0 comments Download
M test/debugger/debug/debug-script.js View 2 chunks +2 lines, -3 lines 0 comments Download
A + test/debugger/debug/debug-set-variable-value.js View 6 chunks +0 lines, -54 lines 0 comments Download
A + test/debugger/debug/es6/debug-function-scopes.js View 5 chunks +54 lines, -34 lines 0 comments Download
A + test/debugger/debug/regress/regress-frame-details-null-receiver.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/debugger.status View 1 chunk +2 lines, -1 line 0 comments Download
M test/debugger/test-api.js View 2 chunks +22 lines, -1 line 0 comments Download
D test/mjsunit/debug-conditional-breakpoints.js View 1 chunk +0 lines, -154 lines 0 comments Download
D test/mjsunit/debug-evaluate-shadowed-context.js View 1 chunk +0 lines, -83 lines 0 comments Download
D test/mjsunit/debug-function-scopes.js View 1 chunk +0 lines, -156 lines 0 comments Download
D test/mjsunit/debug-multiple-breakpoints.js View 1 chunk +0 lines, -105 lines 0 comments Download
D test/mjsunit/debug-negative-break-points.js View 1 chunk +0 lines, -99 lines 0 comments Download
D test/mjsunit/debug-receiver.js View 1 chunk +0 lines, -124 lines 0 comments Download
D test/mjsunit/debug-set-variable-value.js View 1 chunk +0 lines, -338 lines 0 comments Download
D test/mjsunit/es6/debug-function-scopes.js View 1 chunk +0 lines, -116 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
D test/mjsunit/regress/regress-frame-details-null-receiver.js View 1 chunk +0 lines, -51 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
jgruber
4 years, 1 month ago (2016-11-21 09:00:40 UTC) #14
Yang
On 2016/11/21 09:00:40, jgruber wrote: lgtm.
4 years, 1 month ago (2016-11-22 09:23:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512963002/20001
4 years, 1 month ago (2016-11-22 12:17:25 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 12:43:46 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 12:44:22 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/facd6b9a4abb8d612d2b21a669dc4c9771945863
Cr-Commit-Position: refs/heads/master@{#41175}

Powered by Google App Engine
This is Rietveld 408576698