Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2514303003: [debug-wrapper] Implement StepFrame through runtime (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] Implement StepFrame through runtime StepFrame is a combination of StepIn/StepOut, e.g. it breaks to the next frame change. This is not part of the public API, but we want to keep it for internal tests. BUG=v8:5530 Committed: https://crrev.com/a0e9160066c2947f7dc7575287fe2442141f19c8 Cr-Commit-Position: refs/heads/master@{#41177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -209 lines) Patch
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A + test/debugger/debug/debug-stepframe.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/debug-stepframe-clearing.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/test-api.js View 1 chunk +1 line, -0 lines 0 comments Download
D test/mjsunit/debug-stepframe.js View 1 chunk +0 lines, -110 lines 0 comments Download
D test/mjsunit/debug-stepframe-clearing.js View 1 chunk +0 lines, -97 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
jgruber
4 years, 1 month ago (2016-11-21 10:43:10 UTC) #6
Yang
On 2016/11/21 10:43:10, jgruber wrote: lgtm. thanks.
4 years, 1 month ago (2016-11-21 13:20:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514303003/1
4 years, 1 month ago (2016-11-22 12:45:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 13:14:36 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 13:15:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0e9160066c2947f7dc7575287fe2442141f19c8
Cr-Commit-Position: refs/heads/master@{#41177}

Powered by Google App Engine
This is Rietveld 408576698