Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2505363002: [debug-wrapper] Adapt tests, breakpoint.actual_location (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] Adapt tests, breakpoint.actual_location Adapted various tests to restrictions of inspector protocol: * osr-typing-debug-change: Don't set function variable value. * debug-evaluate-locals: Add variable introduced by eval, run typeof inside evaluate(). * regress-419663: Don't set duplicate breakpoints. * regress-crbug-465298: Compare against function name instead of value. * regress-crbug-621361: Make evaluate return string results. * debug-script: Various counts were off due to new way tests are called. Added new inspector script type. Breakpoints now contain the actual break position, and remote object reconstruction has been extended a bit. BUG=v8:5530 Committed: https://crrev.com/1834ab724614416d4c5dc2025b9e59599e148198 Cr-Commit-Position: refs/heads/master@{#41129}

Patch Set 1 #

Patch Set 2 : Fix failures #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -1863 lines) Patch
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A + test/debugger/debug/compiler/osr-typing-debug-change.js View 1 3 chunks +1 line, -6 lines 0 comments Download
A + test/debugger/debug/debug-evaluate-locals.js View 3 chunks +6 lines, -6 lines 0 comments Download
A + test/debugger/debug/debug-liveedit-double-call.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/debug-script.js View 3 chunks +7 lines, -3 lines 0 comments Download
A + test/debugger/debug/es6/debug-promises/reject-with-invalid-reject.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-promises/reject-with-throw-in-reject.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-promises/reject-with-undefined-reject.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-scope-default-param-with-eval.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-stepin-microtasks.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-419663.js View 1 3 chunks +3 lines, -8 lines 0 comments Download
A + test/debugger/debug/regress/regress-crbug-424142.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-465298.js View 2 chunks +2 lines, -3 lines 0 comments Download
A + test/debugger/debug/regress/regress-crbug-487289.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-491943.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-517592.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-568477-2.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-621361.js View 2 chunks +3 lines, -4 lines 0 comments Download
M test/debugger/debugger.status View 1 2 3 chunks +33 lines, -0 lines 0 comments Download
M test/debugger/test-api.js View 1 10 chunks +84 lines, -33 lines 0 comments Download
D test/mjsunit/compiler/osr-typing-debug-change.js View 1 chunk +0 lines, -119 lines 0 comments Download
D test/mjsunit/debug-evaluate-locals.js View 1 chunk +0 lines, -149 lines 0 comments Download
D test/mjsunit/debug-evaluate-nested.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/mjsunit/debug-is-active.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/mjsunit/debug-liveedit-breakpoints.js View 1 chunk +0 lines, -115 lines 0 comments Download
D test/mjsunit/debug-liveedit-double-call.js View 1 chunk +0 lines, -142 lines 0 comments Download
M test/mjsunit/debug-receiver.js View 2 chunks +0 lines, -2 lines 0 comments Download
D test/mjsunit/debug-script.js View 1 chunk +0 lines, -108 lines 0 comments Download
D test/mjsunit/debug-script-breakpoints.js View 1 chunk +0 lines, -125 lines 0 comments Download
D test/mjsunit/debug-script-breakpoints-closure.js View 1 chunk +0 lines, -67 lines 0 comments Download
D test/mjsunit/debug-script-breakpoints-nested.js View 1 chunk +0 lines, -82 lines 0 comments Download
D test/mjsunit/debug-set-script-source.js View 1 chunk +0 lines, -64 lines 0 comments Download
D test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js View 1 chunk +0 lines, -74 lines 0 comments Download
D test/mjsunit/es6/debug-promises/reject-with-throw-in-reject.js View 1 chunk +0 lines, -84 lines 0 comments Download
D test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js View 1 chunk +0 lines, -74 lines 0 comments Download
D test/mjsunit/es6/debug-scope-default-param-with-eval.js View 1 chunk +0 lines, -61 lines 0 comments Download
D test/mjsunit/es6/debug-stepin-microtasks.js View 1 chunk +0 lines, -75 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 5 chunks +0 lines, -31 lines 0 comments Download
D test/mjsunit/regress/regress-419663.js View 1 chunk +0 lines, -37 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-259300.js View 1 chunk +0 lines, -48 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-424142.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-465298.js View 1 chunk +0 lines, -55 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-487289.js View 1 chunk +0 lines, -20 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-491943.js View 1 chunk +0 lines, -25 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-517592.js View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-568477-2.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-621361.js View 1 chunk +0 lines, -40 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
jgruber
4 years, 1 month ago (2016-11-17 14:01:17 UTC) #8
Yang
On 2016/11/17 14:01:17, jgruber wrote: lgtm.
4 years, 1 month ago (2016-11-21 09:12:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505363002/40001
4 years, 1 month ago (2016-11-21 09:26:48 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 09:28:59 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 09:29:31 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1834ab724614416d4c5dc2025b9e59599e148198
Cr-Commit-Position: refs/heads/master@{#41129}

Powered by Google App Engine
This is Rietveld 408576698