Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2512463002: Revert of Refactor SharedFunctionInfo::IsBuiltin. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, ulan, Yang
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Refactor SharedFunctionInfo::IsBuiltin. (patchset #1 id:1 of https://codereview.chromium.org/2505853003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11394 Original issue's description: > Refactor SharedFunctionInfo::IsBuiltin. > > This method is a slight misnomer. What we actually want to know is > whether the function was defined in a user-provided script. > > Also remove redundant Script::hide_source flag. > > R=bmeurer@chromium.org, ulan@chromium.org TBR=bmeurer@chromium.org,ulan@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1160e5edccdecb282c9fd8ad36acbfb4400b5243 Cr-Commit-Position: refs/heads/master@{#41050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -46 lines) Patch
M src/accessors.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/prettyprinter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ast/prettyprinter.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 3 chunks +9 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +10 lines, -4 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Refactor SharedFunctionInfo::IsBuiltin.
4 years, 1 month ago (2016-11-16 19:47:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512463002/1
4 years, 1 month ago (2016-11-16 19:47:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 19:48:03 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1160e5edccdecb282c9fd8ad36acbfb4400b5243
Cr-Commit-Position: refs/heads/master@{#41050}

Powered by Google App Engine
This is Rietveld 408576698