src/ic/ic.cc - Issue 2512463002: Revert of Refactor SharedFunctionInfo::IsBuiltin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 2512463002: Revert of Refactor SharedFunctionInfo::IsBuiltin. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 07bd68dfbf9caea4e19bd49996bc396b62527e91..bcd98f156ce7e203d610ea6b2b6893c9b0d02096 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1033,7 +1033,7 @@

if (holder->HasFastProperties()) {

if (getter->IsJSFunction()) {

Handle<JSFunction> function = Handle<JSFunction>::cast(getter);

- if (!receiver->IsJSObject() && function->shared()->IsUserJavaScript() &&

+ if (!receiver->IsJSObject() && !function->shared()->IsBuiltin() &&

is_sloppy(function->shared()->language_mode())) {

// Calling sloppy non-builtins with a value as the receiver

// requires boxing.

« no previous file with comments | « src/heap/objects-visiting-inl.h ('k') | src/isolate.cc » ('j') | no next file with comments »