src/compiler/pipeline.cc - Issue 2512463002: Revert of Refactor SharedFunctionInfo::IsBuiltin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/pipeline.cc

Issue 2512463002: Revert of Refactor SharedFunctionInfo::IsBuiltin. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/pipeline.cc

diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc

index 5be72c6684196a9b57189a941404242d3e100f54..934f4be17df9ba94d75435a79e9d8e23e8d557cd 100644

--- a/src/compiler/pipeline.cc

+++ b/src/compiler/pipeline.cc

@@ -1507,7 +1507,7 @@

// Determine the Typer operation flags.

Typer::Flags flags = Typer::kNoFlags;

if (is_sloppy(info()->shared_info()->language_mode()) &&

- info()->shared_info()->IsUserJavaScript()) {

+ !info()->shared_info()->IsBuiltin()) {

// Sloppy mode functions always have an Object for this.

flags |= Typer::kThisIsReceiver;

}

« no previous file with comments | « src/compiler/js-inlining-heuristic.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »