[Extensions Bindings] Add ExtensionBindingsSystem interface; hook it up

[Extensions Bindings] Add ExtensionBindingsSystem interface; hook it up

Add an ExtensionBindingsSystem interface to handle exposing bindings to
extension contexts, extension API calls and responses, and dispatching
events.

Pull much of the current JS binding logic out of the dispatcher and into
a JsExtensionBindingsSystem implementation; this will allow the bindings
system associated with the dispatcher to be easily switched out as we
migrate to native bindings.

Update NativeExtensionBindingsSystem to implement
ExtensionBindingsSystem fully.

BUG=653596
Committed: https://crrev.com/9f33889e52c1a6311fd94db31be14fa07a8ad668
Cr-Commit-Position: refs/heads/master@{#433605}

[Devlin, 2016-11-18 21:51:47]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[Devlin, 2016-11-18 21:51:54]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-11-18 21:52:42]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-11-18 21:52:42]

lazyboy@, mind taking a look?  This basically just pulls most of the dispatcher
code to set up bindings into a separate class so we can easily swap it out.

cc jbroman as FYI

[commit-bot: I haz the power, 2016-11-18 21:52:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:10:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:10:25]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[lazyboy, 2016-11-19 03:23:02]

lgtm with a few nits

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/ext...
File extensions/renderer/extension_bindings_system.h (right):

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/ext...
extensions/renderer/extension_bindings_system.h:47: // Handles the response
associated with the given |id|.
|request_id| or just id to use it as a word

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/js_...
File extensions/renderer/js_extension_bindings_system.cc (right):

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/js_...
extensions/renderer/js_extension_bindings_system.cc:113: if (bind_name)
Is |bind_name| ever null?

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/wor...
File extensions/renderer/worker_thread_dispatcher.cc (right):

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/wor...
extensions/renderer/worker_thread_dispatcher.cc:30: // native bindings. We
should instead be going through the bindings system.
nit: expand this a bit to make it clearer: as far as I understand:
instead of native bindings -> use NativeExtensionBindingsSystem.
And "going through the bindings system" -> going through |bindings_system()|

[Devlin, 2016-11-21 17:51:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 17:52:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:14:03]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-11-21 19:29:41]

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/ext...
File extensions/renderer/extension_bindings_system.h (right):

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/ext...
extensions/renderer/extension_bindings_system.h:47: // Handles the response
associated with the given |id|.
On 2016/11/19 03:23:01, lazyboy wrote:
> |request_id| or just id to use it as a word

Done.

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/js_...
File extensions/renderer/js_extension_bindings_system.cc (right):

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/js_...
extensions/renderer/js_extension_bindings_system.cc:113: if (bind_name)
On 2016/11/19 03:23:01, lazyboy wrote:
> Is |bind_name| ever null?

Nope, removed.

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/wor...
File extensions/renderer/worker_thread_dispatcher.cc (right):

https://codereview.chromium.org/2512233002/diff/20001/extensions/renderer/wor...
extensions/renderer/worker_thread_dispatcher.cc:30: // native bindings. We
should instead be going through the bindings system.
On 2016/11/19 03:23:01, lazyboy wrote:
> nit: expand this a bit to make it clearer: as far as I understand:
> instead of native bindings -> use NativeExtensionBindingsSystem.
> And "going through the bindings system" -> going through |bindings_system()|

Done.

[Devlin, 2016-11-21 19:29:46]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-11-21 19:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2512233002/#ps40001
(title: "lazyboys")

[commit-bot: I haz the power, 2016-11-21 19:30:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:37:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479756586016290,
"parent_rev": "6b4e8b65f23e802f1839470c5d846c13be964519", "commit_rev":
"ad424bbd4fa6d9ed62dc39d8487689d7c7cf4280"}

[commit-bot: I haz the power, 2016-11-21 19:37:32]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-21 19:40:51]

Description was changed from

==========
[Extensions Bindings] Add ExtensionBindingsSystem interface; hook it up

Add an ExtensionBindingsSystem interface to handle exposing bindings to
extension contexts, extension API calls and responses, and dispatching
events.

Pull much of the current JS binding logic out of the dispatcher and into
a JsExtensionBindingsSystem implementation; this will allow the bindings
system associated with the dispatcher to be easily switched out as we
migrate to native bindings.

Update NativeExtensionBindingsSystem to implement
ExtensionBindingsSystem fully.

BUG=653596
==========

to

==========
[Extensions Bindings] Add ExtensionBindingsSystem interface; hook it up

Add an ExtensionBindingsSystem interface to handle exposing bindings to
extension contexts, extension API calls and responses, and dispatching
events.

Pull much of the current JS binding logic out of the dispatcher and into
a JsExtensionBindingsSystem implementation; this will allow the bindings
system associated with the dispatcher to be easily switched out as we
migrate to native bindings.

Update NativeExtensionBindingsSystem to implement
ExtensionBindingsSystem fully.

BUG=653596

Committed: https://crrev.com/9f33889e52c1a6311fd94db31be14fa07a8ad668
Cr-Commit-Position: refs/heads/master@{#433605}
==========

[commit-bot: I haz the power, 2016-11-21 19:40:52]

Patchset 2 (id:??) landed as
https://crrev.com/9f33889e52c1a6311fd94db31be14fa07a8ad668
Cr-Commit-Position: refs/heads/master@{#433605}