Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2476)

Unified Diff: extensions/renderer/dispatcher.h

Issue 2512233002: [Extensions Bindings] Add ExtensionBindingsSystem interface; hook it up (Closed)
Patch Set: lazyboys Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/BUILD.gn ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/dispatcher.h
diff --git a/extensions/renderer/dispatcher.h b/extensions/renderer/dispatcher.h
index 0e8d57927a08faa58793458a9697807e699af965..578ad24a271c3323d2a7791cef7385c515cfa64f 100644
--- a/extensions/renderer/dispatcher.h
+++ b/extensions/renderer/dispatcher.h
@@ -62,6 +62,7 @@ namespace extensions {
class ContentWatcher;
class DispatcherDelegate;
class FilteredEventRouter;
+class JsExtensionBindingsSystem;
class ManifestPermissionSet;
class RequestSender;
class ScriptContext;
@@ -84,8 +85,6 @@ class Dispatcher : public content::RenderThreadObserver,
ContentWatcher* content_watcher() { return content_watcher_.get(); }
- RequestSender* request_sender() { return request_sender_.get(); }
-
const std::string& webview_partition_id() { return webview_partition_id_; }
bool activity_logging_enabled() const { return activity_logging_enabled_; }
@@ -229,17 +228,11 @@ class Dispatcher : public content::RenderThreadObserver,
void UpdateBindingsForContext(ScriptContext* context);
- void RegisterBinding(const std::string& api_name, ScriptContext* context);
-
void RegisterNativeHandlers(ModuleSystem* module_system,
ScriptContext* context,
RequestSender* request_sender,
V8SchemaRegistry* v8_schema_registry);
- // Determines if a ScriptContext can connect to any externally_connectable-
- // enabled extension.
- bool IsRuntimeAvailableToContext(ScriptContext* context);
-
// Updates a web page context with any content capabilities granted by active
// extensions.
void UpdateContentCapabilities(ScriptContext* context);
@@ -250,18 +243,6 @@ class Dispatcher : public content::RenderThreadObserver,
// Returns whether the current renderer hosts a platform app.
bool IsWithinPlatformApp();
- // Gets |field| from |object| or creates it as an empty object if it doesn't
- // exist.
- static v8::Local<v8::Object> GetOrCreateObject(
- const v8::Local<v8::Object>& object,
- const std::string& field,
- v8::Isolate* isolate);
-
- static v8::Local<v8::Object> GetOrCreateBindObjectIfAvailable(
- const std::string& api_name,
- std::string* bind_name,
- ScriptContext* context);
-
// Requires the GuestView modules in the module system of the ScriptContext
// |context|.
void RequireGuestViewModules(ScriptContext* context);
@@ -299,8 +280,8 @@ class Dispatcher : public content::RenderThreadObserver,
// Cache for the v8 representation of extension API schemas.
std::unique_ptr<V8SchemaRegistry> v8_schema_registry_;
- // Sends API requests to the extension host.
- std::unique_ptr<RequestSender> request_sender_;
+ // The bindings system associated with the main thread.
+ std::unique_ptr<JsExtensionBindingsSystem> bindings_system_;
// The platforms system font family and size;
std::string system_font_family_;
« no previous file with comments | « extensions/renderer/BUILD.gn ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698