Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: extensions/renderer/native_extension_bindings_system.cc

Issue 2512233002: [Extensions Bindings] Add ExtensionBindingsSystem interface; hook it up (Closed)
Patch Set: lazyboys Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/native_extension_bindings_system.cc
diff --git a/extensions/renderer/native_extension_bindings_system.cc b/extensions/renderer/native_extension_bindings_system.cc
index 089d339d80ebf7a7ae145e7a22ced50967b4bd26..7e56635dfbfc03d70f5b53d37d5994b2b784d616 100644
--- a/extensions/renderer/native_extension_bindings_system.cc
+++ b/extensions/renderer/native_extension_bindings_system.cc
@@ -91,7 +91,13 @@ NativeExtensionBindingsSystem::NativeExtensionBindingsSystem(
NativeExtensionBindingsSystem::~NativeExtensionBindingsSystem() {}
-void NativeExtensionBindingsSystem::CreateAPIsInContext(
+void NativeExtensionBindingsSystem::DidCreateScriptContext(
+ ScriptContext* context) {}
+
+void NativeExtensionBindingsSystem::WillReleaseScriptContext(
+ ScriptContext* context) {}
+
+void NativeExtensionBindingsSystem::UpdateBindingsForContext(
ScriptContext* context) {
v8::Local<v8::Context> v8_context = context->v8_context();
v8::Local<v8::Object> chrome = GetOrCreateChrome(v8_context);
@@ -136,13 +142,30 @@ void NativeExtensionBindingsSystem::CreateAPIsInContext(
}
}
-void NativeExtensionBindingsSystem::OnResponse(int request_id,
- bool success,
- const base::ListValue& response,
- const std::string& error) {
+void NativeExtensionBindingsSystem::DispatchEventInContext(
+ const std::string& event_name,
+ const base::ListValue* event_args,
+ const base::DictionaryValue* filtering_info,
+ ScriptContext* context) {
+ v8::HandleScope handle_scope(context->isolate());
+ v8::Context::Scope context_scope(context->v8_context());
+ // TODO(devlin): Take into account |filtering_info|.
+ api_system_.FireEventInContext(event_name, context->v8_context(),
+ *event_args);
+}
+
+void NativeExtensionBindingsSystem::HandleResponse(
+ int request_id,
+ bool success,
+ const base::ListValue& response,
+ const std::string& error) {
api_system_.CompleteRequest(request_id, response);
}
+RequestSender* NativeExtensionBindingsSystem::GetRequestSender() {
+ return nullptr;
+}
+
void NativeExtensionBindingsSystem::SendRequest(
std::unique_ptr<APIBindingsSystem::Request> request,
v8::Local<v8::Context> context) {

Powered by Google App Engine
This is Rietveld 408576698