Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2511803002: Convert CFWL_EvtSpbClick to CFWL_EvtClick (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert CFWL_EvtSpbClick to CFWL_EvtClick The m_bUp flag of CFWL_EvtSpbClick is never used after being set. Remove the flag and replace CFWL_EvtSpbClick with CFWL_EvtClick. Committed: https://pdfium.googlesource.com/pdfium/+/e7798055382d2694e2ce78e5330af20c741d0a84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M xfa/fwl/core/ifwl_spinbutton.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.cpp View 4 chunks +7 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-17 16:42:34 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-17 17:09:00 UTC) #3
npm
lgtm
4 years, 1 month ago (2016-11-17 17:18:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511803002/1
4 years, 1 month ago (2016-11-17 17:27:38 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 17:50:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/e7798055382d2694e2ce78e5330af20c741d...

Powered by Google App Engine
This is Rietveld 408576698