Issue 2508203002: Convert single use EventTypes to class files.

Issue 2508203002: Convert single use EventTypes to class files. (Closed)

Created:
4 years, 1 month ago by dsinclair

Modified:
4 years, 1 month ago

Reviewers:
Tom Sepez, npm

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Convert single use EventTypes to class files. This moves the remaining EventType class definitions to there own files where the EventType only has a single implementation. Committed: https://pdfium.googlesource.com/pdfium/+/a43715b4cefc982baadd45510db8c4e428c2c8cd

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -46 lines)			Patch
M	BUILD.gn	View	2 chunks	+6 lines, -0 lines	0 comments	Download
A +	xfa/fwl/core/cfwl_evtcheckstatechanged.h	View	1 chunk	+6 lines, -10 lines	0 comments	Download
A	xfa/fwl/core/cfwl_evtcheckstatechanged.cpp	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	xfa/fwl/core/cfwl_evtpostdropdown.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
A +	xfa/fwl/core/cfwl_evtpostdropdown.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A +	xfa/fwl/core/cfwl_evtpredropdown.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
A +	xfa/fwl/core/cfwl_evtpredropdown.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	xfa/fwl/core/ifwl_checkbox.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	xfa/fwl/core/ifwl_checkbox.cpp	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	xfa/fwl/core/ifwl_combobox.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	xfa/fwl/core/ifwl_combobox.cpp	View	4 chunks	+5 lines, -3 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 11 (7 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508203002/1

4 years, 1 month ago (2016-11-17 17:25:59 UTC) #9

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 17:26:16 UTC) #11

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a43715b4cefc982baadd45510db8c4e428c2...